commit 0162baed1317862d7081dcece953eda7fef34a0f
author Collin Baker <collinbaker@chromium.org> Thu Apr 03 18:01:40 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Apr 03 18:01:40 2025
tree b074a89afe437dc763c91b41a8536e95326cf3ac
parent 19aa3c93bbfe40780404be51fc58baefff2ced7e

Revert "Reland "Reland "Use string_view in logging and trace_event location"""

This reverts commit 39f387dc54979430f65b7746ca96229711d10ce8.

Reason for revert: crashes again seen in crbug.com/406443772

Original change's description:
> Reland "Reland "Use string_view in logging and trace_event location""
>
> This reverts commit dc4db77918ca8221cc6ede659faa43112bcaccfe.
>
> Fixes construction of std::string_view with nullptr
>
> Original change's description:
> > Revert "Reland "Use string_view in logging and trace_event location""
> >
> > This reverts commit 57368cb688f57953997281524e3a9733c535393b.
> >
> > Reason for revert: crbug.com/406443772
> >
> > Original change's description:
> > > Reland "Use string_view in logging and trace_event location"
> > >
> > > This is a reland of commit 5439f8eb1e170ce515a12e211b5d20a2bff75ea5
> > >
> > > Original change's description:
> > > > Use string_view in logging and trace_event location
> > > >
> > > > Changes the LogMessage class to use a string_view for file names. This
> > > > required a matching change in trace_event: a const char* string was
> > > > passed from logging code, but there is no safe way to get a const
> > > > char* from a string_view since the latter may not be null-terminated.
> > > >
> > > > Many clients of base/logging.h are updated to use string_view as well.
> > > >
> > > > Code which attempts to pass a string_view to a LogMessage by its data
> > > > pointer already exists:
> > > > https://source.chromium.org/chromium/chromium/src/+/main:ash/quick_pair/common/logging.cc;l=49;drc=c6c99d03b1d2f4fab91d6be8665f81b540690c73
> > > > https://source.chromium.org/chromium/chromium/src/+/main:components/cross_device/logging/logging.cc;l=30;drc=00704dbac4f63b2476aac319572ffc42c9b71fc2
> > > >
> > > > Desire for Rust logging support prompted this change. In principle a
> > > > Rust log facility can be a thin wrapper around the base logging
> > > > implementation, but Rust has almost no support for null-terminated
> > > > strings. Instead, Rust provides a string_view equivalent built in to
> > > > the language. This change enables Rust code to pass file names
> > > > obtained by language-specific macros to the C++ implementation.
> > > >
> > > > Bug: None
> > > > Change-Id: I21b4f1c945b70d54f66d80adf3dcda1fe5a39f71
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5765705
> > > > Reviewed-by: Peter Boström <pbos@chromium.org>
> > > > Auto-Submit: Collin Baker <collinbaker@chromium.org>
> > > > Commit-Queue: Collin Baker <collinbaker@chromium.org>
> > > > Reviewed-by: Stephen Nusko <nuskos@chromium.org>
> > > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > > > Owners-Override: Daniel Cheng <dcheng@chromium.org>
> > > > Cr-Commit-Position: refs/heads/main@{#1436283}
> > >
> > > Bug: None
> > > Change-Id: I725bac881a160caa6d97e7480bc4047b460fae34
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6387020
> > > Commit-Queue: Collin Baker <collinbaker@chromium.org>
> > > Reviewed-by: Peter Boström <pbos@chromium.org>
> > > Owners-Override: Daniel Cheng <dcheng@chromium.org>
> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > > Reviewed-by: Stephen Nusko <nuskos@chromium.org>
> > > Cr-Commit-Position: refs/heads/main@{#1437625}
> >
> > Bug: None
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Change-Id: Ia4a01ddf6af5068d38b13971e09eb8146bd4d2d2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6395097
> > Commit-Queue: Collin Baker <collinbaker@chromium.org>
> > Owners-Override: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Cr-Commit-Position: refs/heads/main@{#1438193}
>
> Bug: None
> Change-Id: I3b9092a97df46c6bd89f5fb152b7736768b51c42
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6416567
> Owners-Override: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Collin Baker <collinbaker@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1440526}

Bug: None
Change-Id: I529542cd0070088b9f4f1a538a3a6b7fbe01b3d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6430129
Auto-Submit: Collin Baker <collinbaker@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1442287}