commit | 016e3bebda2a4b0a987a38425b718682af51a225 | [log] [tgz] |
---|---|---|
author | Chia-I Wu <olv@google.com> | Fri Nov 10 17:05:53 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Nov 10 17:05:53 2023 |
tree | b02b2e282e1e9e05f5c984cded402e97b1090040 | |
parent | f0cc351d608b8aac57e8fd09ae9e74daa1827e99 [diff] |
exo: respect DRM_FORMAT_MOD_LINEAR sommelier uses DRM_IOCTL_VIRTGPU_RESOURCE_INFO_CROS and falls back to DRM_FORMAT_MOD_INVALID. The ioctl returns the info queried from virgl_renderer_export_query which calls gbm_bo_get_modifier in the host. arc++/arcvm uses GRALLOC_DRM_GET_BUFFER_INFO and falls back to DRM_FORMAT_MOD_LINEAR. On arcvm, the query uses DRM_IOCTL_VIRTGPU_RESOURCE_INFO_CROS. On arc++, the query calls drv_bo_get_format_modifier. Other than the arc++/arcvm fallback, which should never happen, DRM_FORMAT_MOD_LINEAR means linear. We don't need the workaround anymore. The workaround treats DRM_FORMAT_MOD_LINEAR as DRM_FORMAT_MOD_INVALID. VulkanImplementationGbm::CreateImageFromGpuMemoryHandle picks VK_IMAGE_TILING_OPTIMAL when the modifier is invalid. That breaks imports of linear buffers. Bug: b/308875771 Test: arcvm on rex Change-Id: I4a4cb4908b633d3cdf9855497a4ef26b32f6d62d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5015313 Commit-Queue: Chia-I Wu <olv@google.com> Reviewed-by: Peter McNeeley <petermcneeley@chromium.org> Reviewed-by: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/main@{#1222986}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.