dpwas: Update protocol check to validate against specific webapp

web_app_start_utils.cc doesn't need to check for all apps, only the
app specified via the command line and deletes some dead code.

With the dead code removed, ProtocolHandlerManagerTest is no longer
needed, which then left WebAppProtocolHandlerManager with zero unit
test coverage. This change also adds new unit test coverage for
WebAppProtocolHandlerManager.

Repro steps:

1) Install https://mwjacksonmsft.github.io/pwa/display-standalone/
2) Run chrome_proxy.exe --app-id=cppdpmhljndhkpjhhflifimgckghnmak web+testing://test
   This should prompt the user for a protocol handler launch.
3) Run chrome_proxy.exe --app-id=cppdpmhljndhkpjhhflifimgckghnmak web+test://test
   This should not prompt, and load the app at the default entry point.

Bug: 1249907
Change-Id: Ia155db2e30e4c1fd12628714d33c49dc3155e8f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3617362
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#998430}
15 files changed
tree: 501edf35a6152146b05bb9b2fd644023e8cbbeae
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.