commit	01c54660c8caf89ba2f18b8794dc7beddd249c7a	[log] [tgz]
author	Matthew Denton <mpdenton@chromium.org>	Fri Mar 24 18:51:21 2023
committer	Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>	Fri Mar 24 18:51:21 2023
tree	26f56a00157c2216f4d1ee8162166ef6a050fae5
parent	c5549dbbe8d3990bb1d4ade867d4cb24496ee039 [diff]

Rename NetworkChangeNotifierPosix -> NetworkChangeNotifierPassive

NetworkChangeNotifierPosix:
1. Relies on 0 Posix-specific behavior
2. Currently is compiled into only a subset of Chrome's Posix platforms
3. Could run perfectly fine on non-Posix platforms
4. Is not a descriptive name about what it does
5. Misleads into thinking it's a drop-in replacement for, e.g.
   NetworkChangeNotifierLinux, that works using only Posix APIs (it's
   not a drop-in replacement as it doesn't do anything on its own).

So rename it to NetworkChangeNotifierPassive.

Bug: 1312226
Change-Id: Ia2c8528971274004ab7ac87fcea96a659fc12960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4363208
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Matthew Denton <mpdenton@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121846}

chrome/browser/ash/chrome_browser_main_parts_ash.cc[diff]
chrome/browser/ash/network_change_manager_client.cc[diff]
chrome/browser/ash/network_change_manager_client.h[diff]
chrome/browser/ash/network_change_manager_client_unittest.cc[diff]
chrome/browser/lacros/net/network_change_manager_bridge.cc[diff]
chrome/browser/lacros/net/network_change_manager_bridge.h[diff]
content/public/test/network_connection_change_simulator.cc[diff]
net/BUILD.gn[diff]
net/base/network_change_notifier.cc[diff]
net/base/network_change_notifier_passive.cc[Renamed from net/base/network_change_notifier_posix.cc - diff]
net/base/network_change_notifier_passive.h[Renamed from net/base/network_change_notifier_posix.h - diff]
net/base/network_change_notifier_passive_unittest.cc[Renamed from net/base/network_change_notifier_posix_unittest.cc - diff]
services/network/network_change_manager.cc[diff]
services/network/network_service.cc[diff]

14 files changed

tree: 26f56a00157c2216f4d1ee8162166ef6a050fae5

README.md

Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.