Fix crash in AddToTopLayer It is possible, via a convoluted and not very reproducable repro, to add a ::backdrop pseudo element to something that isn't in the top layer. See crbug.com/410437529. This CL fixes that by making sure the element is (still) in the top layer before adding the backdrop pseudo element to the top layer. It also converts a few DCHECKs (that hit on the repro) to CHECKs. Fixed: 410437529 Change-Id: I85d63282a9b7f5161ab8d22e5bfeec013626ad04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6491968 Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1452103}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.