commit | 0200e0cb1f0609af398d049afb134bfff10c4a07 | [log] [tgz] |
---|---|---|
author | Simon Zünd <szuend@chromium.org> | Tue Nov 02 10:41:50 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Nov 02 10:41:50 2021 |
tree | 918fc1e4e8e028ad298ea98e4d43ce86bac0d4cc | |
parent | 8d2af0f8423065e9b4225eebc9fcc1de9cc48691 [diff] |
[test] Use 127.0.0.1 instead of localhost for DevTools This CL fixes timeouts when running DevTools web tests massively in parallel (e.g. via the `-f` option for run_web_test.py). DevTools web tests have two WebContents. One loads the DevTools frontend plus the test source, while the second loads the inspected page resources. In content_shell the DevTools frontend is loaded via apache. The devtools:// scheme is only available in chrome. Currently, the DevTools frontend is loaded via `localhost`, while the test source and the inspected page resources are loaded from `127.0.0.1`. This is a mismatch, as the DevTools page (i.e. integration_test_runner.html) dynamically imports from a different origin. Either loading DevTools from `127.0.0.1` or loading the test source from `localhost` fixes the issue, as the dynamic import is now same-origin. We are not sure why though. Regardless, its probably better to be consistent and load from the same origin in the DevTools WebContents. R=alexrudenko@chromium.org Bug: None Change-Id: Ib13af2dd1a705bdc9a780a4d3f08351d2cf1fa5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3250903 Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#937261}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.