commit 02259024f02e977e4ddaf22a851c9bbaaee257b0
author Calder Kitagawa <ckitagawa@chromium.org> Mon Sep 23 18:39:15 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Sep 23 18:39:15 2024
tree c74ed812d802f9d4f9e476760653521a7304f544
parent 62d45287362d24860978899c24f268224206c5ae

[Tab Switcher] Update ActionConfirmationManager for collaborations

Strings
* Add strings for keep tab group dialog.

ActionConfirmationDialog
* Expose ButtonClickResult to caller instead of handling internally so
  that more accurate metrics are possible for keep tab group dialog.

ActionConfirmationManager
* Rename processRemove* to processUngroup* to disambiguate as remove
  means Ungroup OR Close.
* Handle new ButtonClickResult ActionConfirmationDialog output correctly
  in existing flows.
* Add methods to show a keep tab group dialog for member and owners.
  This is similar to processGroupNameAction, but supports additional
  metrics outputs and default the NO_CLICK behavior to be positive as it
  is safer for these case.
* Add TODOs to remove the reliance on TabGroupModelFilter. The plan is
  to create a wrapper class that will pre-process all types of tab
  removal (ungroup or close) and will figure out which dialog to show.
* Reorder methods so leave and delete (as owner) are adjacent.

Bug: 347981397, 347981662
Change-Id: Icf437804e20514c240609e5ae0fafc3a1cce116a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5877999
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1358888}