Google Git
Sign in
chromium / chromium / src / 022c1c63fecca8d5ac7985769a3428fc63babc73
commit022c1c63fecca8d5ac7985769a3428fc63babc73[log] [tgz]
authorMike Wittman <wittman@chromium.org>Tue Feb 07 01:15:34 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Feb 07 01:15:34 2023
tree44ab70a3e7c619d32ab84bc136e2d144bcbfd89f
parenta20584b9da3a480af76313e00939818196be178a [diff]
Make TaskManagerImpl leaky rather than atexit destroyed

Works around the fact that TaskManagerImpl and its owned task
providers are created on the UI thread but destroyed on a different
thread via atexit. This is blocking removal of the render process
host created notification from RenderProcessHostTaskProvider under
https://crbug.com/357627, which requires destruction, if it occurs,
to happen on the UI thread.

All observers that would cause the TaskManagerImpl to be active are
destroyed during shutdown. So moving to leaky allocation shouldn't
present destruction ordering issues where an active TaskManagerImpl
tries to access destroyed state.

Note that we can't use base::NoDestructor<> for this because the logic
depends on being able to check whether the TaskManagerImpl was created.

Bug: 1409173
Change-Id: Ieb9a4d1363ba5c448b7551df6d59c37cec23c5a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4184773
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1101902}
1 file changed
tree: 44ab70a3e7c619d32ab84bc136e2d144bcbfd89f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.