Move refill event logging from TriggerRefill to OnDidFillOrPreviewForm Previously, TriggerRefill would log metrics using OnDidRefill with an AddressFormEventLogger object, even though those could be triggered for a payments form. Moreover, we used to log this metric at an early stage where refill could still be aborted and not happen. This CL fixes this by moving the logging till after the refill happens and distinguishing between address and credit card event logging. Note that the two functions still run the same logic, but it is now less confusing. Bug: 1517894 Change-Id: Iaca8193d12b8a8583b2d851c0195d0d536e827a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5211032 Reviewed-by: Florian Leimgruber <fleimgruber@google.com> Commit-Queue: Jihad Hanna <jihadghanna@google.com> Cr-Commit-Position: refs/heads/main@{#1250212}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.