| commit | 024c22d9556d1c428bfc1ed4765aa5c8feefcf7d | [log] [tgz] |
|---|---|---|
| author | Elly <ellyjones@chromium.org> | Tue Jan 07 01:14:15 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 07 01:14:15 2025 |
| tree | d876256cde885a1cffacd30197b4030fa71b6903 | |
| parent | 731f28d1d7d70ee70368cf19e6100e1962013bb9 [diff] |
cdm: fix unsafe buffers in cenc_utils This change removes all unsafe buffer uses in cenc_utils and their unit tests. To do that, it: * Migrates the cenc_utils functions from taking const vector<uint8_t>& to taking span<const uint8_t> * Migrates all the test data from uint8_t[] to std::array<uint8_t> * Removes a lot of now-unnecessary vector copies * Includes cenc_utils_unittest.cc in builds with !proprietary_codecs - cenc_utils.cc is included in these builds, so the tests should be as well, and these tests don't depend on proprietary codecs. * Since the test fixture for CencUtilsTest now has no state and does no setup, deletes the test fixture altogether and makes the tests fixtureless. Bug: 383606739 Change-Id: Ib87c1dfd9764e9fe878bcdba3e3399fadc5d4e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088948 Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Elly FJ <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/main@{#1402747}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.