commit | 028204742d5eb09d4106a530222048d086f660e9 | [log] [tgz] |
---|---|---|
author | Igor Ruvinov <igorruvinov@chromium.org> | Thu Jul 27 15:52:38 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jul 27 15:52:38 2023 |
tree | 129d3bedc55d6b5350fca5f9a3f172c5bd101d77 | |
parent | 9d53b4f1c844b35f3d568cc8905d4fa8c3c1f24e [diff] |
Revert "CCA: Make bundled CCA work under subpath" This reverts commit 19ad2292c14471cd481fc1eac607dec4e914b802. Reason for revert: Potential culprit for consistently failing CCAUISmoke test. Sample failure: https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-reven-chrome/7587/overview Original change's description: > CCA: Make bundled CCA work under subpath > > Currently the output of `cca.py bundle` doesn't work when not served > under root of a domain, since there's many reference of URL that start > with '/'. > > To solve this, rewrite all URL pattern in HTML/CSS files to relative > path, and change the path to include subpath in runtime for JS files. > > Bug: b:231413193 > Test: `cca.py dev` and open with local chrome. > Test: `cca.py bundle` and serve with static http server under subpath > Change-Id: I6823f6f3209fb7aa4fea523dba97f45f3210878e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4699163 > Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> > Reviewed-by: Shik Chen <shik@chromium.org> > Reviewed-by: Chu-Hsuan Yang <chuhsuan@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1175964} Bug: b:231413193 Change-Id: I1b02f341f3dd6d72600188bdf8cc713acbceb07e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4726181 Owners-Override: Igor Ruvinov <igorruvinov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1176085}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.