| commit | 02b452c4983f73b2a02e8e69ab6e8e85c8412700 | [log] [tgz] |
|---|---|---|
| author | Alex Gough <ajgo@chromium.org> | Wed Nov 26 18:44:47 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Nov 26 18:44:47 2025 |
| tree | f34d454c3aeff3570ab6b9fd2115fd2173217d71 | |
| parent | ea5a66a857254e4b60fa3d3c964646158594abf6 [diff] |
Remove std::hex and use base::StringPrintf in Windows stacktraces
Before this CL, if an unlisted exception code was encountered in
stack_trace_win.cc it was output using `std:err << std::hex << code`. As
std::hex is sticky, this meant that later line numbers (also DWORDS)
would also be output as hex, confusing some Chromium developers,
especially as this did not always happen.
This CL removes the use of `std::hex` and adds calls to
base::StringPrintf where line numbers, addresses or offsets are output
during stack dumping.
New output:
```
[ RUN ] TakeHandleOfTypeDeathTest.CrazyHandle
Received fatal exception 0xC0000008
KiRaiseUserExceptionDispatcher [0x7ffbc0ca5dba+3a]
base::win::GetObjectTypeName [0x7ffb5af5d534+f4] (D:\chromium\src\base\win\win_util.cc:1188)
base::win::TakeHandleOfType [0x7ffb5af27688+88] (D:\chromium\src\base\win\scoped_handle.cc:70)
```
Bug: 448680449
Change-Id: Ide6c3b54d57ceaf63098e0e12db72934e7ca39a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7206137
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1550632}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.