Google Git
Sign in
chromium / chromium / src / 02b4e5d59cff3b2c1a00f20a5a48f78f068be8cd
commit02b4e5d59cff3b2c1a00f20a5a48f78f068be8cd[log] [tgz]
authorRahul Arakeri <arakeri@microsoft.com>Mon Mar 21 09:14:26 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Mar 21 09:14:26 2022
tree683535d8b6132a48db87475ddc64174ff26cdf99
parent7bafef9c3d7a824a5ec90ca5973cb2145ab582a6 [diff]
Fixed elements without scrollable content shouldn't overscroll.

Bug: When we don't have scrollable content, fixed elements will still
move on overscroll.

Reason: When the content is not scrollable, direct_compositing_reasons
in FragmentPaintPropertyTreeBuilder::UpdatePaintOffsetTranslationis for
fixed elements is always false (even though fixed elements are layered).
Due to this, scroll_translation_for_fixed will be null which in turn
leads to the compositor TransformNode to not gets created for fixed
elements in PropertyTreeManager::EnsureCompositorTransformNode. Without
the cc TransformNode for fixed, we won't be able to apply the inverse
scroll translation that was implemented in crrev.com/c/3493816. If we
have scrollable content on the page, this issue doesn't exist since the
scroll_translation_for_fixed is initialized and the TransformNode gets
created.

Fix: DirectReasonsForPaintPropertiesExceptScrolling should ensure that
fixed elements are assigned a CompositingReason

Change-Id: Icc3dd3d9853f0e3d8a2eec68c7703ae246569aaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537711
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#983232}
2 files changed
tree: 683535d8b6132a48db87475ddc64174ff26cdf99
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.