Google Git
Sign in
chromium / chromium / src / 02d0a33cae78038a71d2d16113964e580c1e9cfd
commit02d0a33cae78038a71d2d16113964e580c1e9cfd[log] [tgz]
authorEric Orth <ericorth@chromium.org>Fri May 19 16:03:36 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 19 16:03:36 2023
tree1544a1c21a896c772bd3cd5803e4b29cad50f870
parent5b2b778b756f8fb1fa91d2d09396cc0ba2868b27 [diff]
Convert DNS results extractor to use new internal results type

HostResolverManager then handles the new type for now by immediately
converting to the old type.  Will convert that in a later CL.

Also, a bit of modernization in the extractor interface:
* Pass references instead of pointers since there's no reason to pass
  nullptr.
* Use base::expected instead of out params for all the error-or-result
  returns.

Minor behavior change, not expected to have any real-world effect:
* Alias parsing now rejects aliases that do not pass a
  dns_names_util::IsValidDnsRecordName() check. This should not affect
  any real-world aliases because it's unlikely a DNS server would ever
  send us such results, and if they ever did, it's a completely
  nonsensical result anyway.

Bug: 1381506
Change-Id: Ib5f6ee4a0fcee05229252ae91b1a1c75d0fd6c40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4504471
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1146536}
9 files changed
tree: 1544a1c21a896c772bd3cd5803e4b29cad50f870
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.