commit | 02fe484fa6a71a559e129663b5602044e443c438 | [log] [tgz] |
---|---|---|
author | Ankush Singh <ankushkush@google.com> | Tue Oct 10 11:30:58 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Oct 10 11:30:58 2023 |
tree | bef418a0d226f78e17fa08ab43cb1a63a45c728f | |
parent | a633216c4f1ad6a752ccf68b65c129557cf3981a [diff] |
[sync] MergePreference() handle case where local value type is incorrect Since pref model associator works directly on the pref store and has no checks whether or not the user pref value is of the correct type, it might be possible that the local value passed to MergePreference() might be corrupt, i.e. of different type than expected. This CL adds a simple check for mergeable list/dict prefs. Bug: 1490835,1485973 Change-Id: I4db69c3fab641212c3f693f6a9bafd8e4a6a465f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4922353 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Ankush Singh <ankushkush@google.com> Cr-Commit-Position: refs/heads/main@{#1207573}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.