Google Git
Sign in
chromium / chromium / src / 030f13f3ef87c96a5ba80914632e2255b3ddeedb
commit030f13f3ef87c96a5ba80914632e2255b3ddeedb[log] [tgz]
authorEmiliaPaz <emiliapaz@chromium.org>Thu Oct 10 19:42:23 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Oct 10 19:42:23 2024
treeed0809b04337105f267739ebd6e79d221f4ab2f6
parentd002f1d911a720adaaf3b0b5efdfdda36ea89925 [diff]
[Extensions c2s] Add MainPageState for extensions menu

Latest UI mocks have changed part of the extensions menu content and
visibility under ExtensionsMenuAccessControl feature flag.

The content in the menu's main page can be better reflected by a
MainPageState enum. Given a state, the view controller can update
the different parts of the main page following MVC.

This CL introduces:
  - MainPageState enum
  - A new string when site for restricted and policy blocked sites
Rest of functionality is kept the same way

Main page update follows:
  1. ExtensionsMenuViewController computes the main page state
  2. Then, given a state it computes the controls values (e.g site
     setting toggle visibility)
  3. Passes those values to ExtensionsMenuMainPageView to update the
     view

Next CLs will:
  - update the message section based on MainPageState and thus get rid
    of MessageSection enum
  - add a tooltip to site settings

Screenshot
- kRestrictedSite:
https://drive.google.com/file/d/1KQszZnyYOGEcRZlHH5QXaMESeD7lJdck/view?usp=drive_link

Bug: 40879945
Change-Id: Ic6ee532988fa693fead19dfd5e047cad1a5076bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5898339
Reviewed-by: Darryl James <dljames@chromium.org>
Commit-Queue: Emilia Paz <emiliapaz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1366996}
7 files changed
tree: ed0809b04337105f267739ebd6e79d221f4ab2f6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.