Google Git
Sign in
chromium / chromium / src / 0317d4c538d6ad100efcae895532381ceef66356
commit0317d4c538d6ad100efcae895532381ceef66356[log] [tgz]
authorDan Clark <daniec@microsoft.com>Wed Jan 24 18:36:13 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 24 18:36:13 2024
tree2a69fda6fd62dcb222b81156afcf620593fd4991
parent09e2fe4b993e2bad4b955c57589f887a42633327 [diff]
[EditContext] Fix indexing in FirstRectForCharacterRange

The `location` parameter to EditContext::FirstRectForCharacterRange is
relative to the entire contents of the editable region, but
character_bounds_ (if HasValidCompositionBounds() is true) is indexed
only relative to the composition range within the editable region.
So, when indexing into character_bounds_ we must adjust `location` by
the start offset of the editable region.

The `length == 0` cases in FirstRectForCharacterRange were failing
to do this adjustment when indexing into character_bounds_.

Fix the array indexing and add a test.

Bug: 1507725
Change-Id: Ie742cfe0c56fb016d70b32b0f13c4d53e94db2d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5219458
Commit-Queue: Dan Clark <daniec@microsoft.com>
Reviewed-by: Anupam Snigdha <snianu@microsoft.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1251542}
2 files changed
tree: 2a69fda6fd62dcb222b81156afcf620593fd4991
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.