commit 0323f5337e310c5477d90a6d8f96150d7ea9f75c
author Trevor Perrier <perrier@chromium.org> Wed Sep 14 20:10:47 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 14 20:10:47 2022
tree 2edc873051af36b73d83bd83112f45b22ab64c55
parent 08b9c1aa12c05589c3718d2fce6df6cfb10dcf34

[LanguageSettings] Fix translate to Chrome format

The purpose of this CL is to fix a bug in the new desktop language
settings when "fil" and "jv" are on the never or always translate
lists.  Like "he" these languages have a different representation in
translate format vs Chrome format.

The conversion for "he" was added in this CL[1] and made the method
`getLanguageCodeWithoutRegion` do more than just return the base
language[2].

This CL cleans up the conversion from translate to Chrome format doing
the following things:

  - rename `getLanguageCodeWithoutRegion` to `getBaseLanguage` and
    have it only remove sub-codes (e.g. en-US -> en).
  - add `convertLanguageCodeForChrome` to match the existing
    `convertLanguageCodeForTranslate` and simplify the Maps backing
    the conversion.
  - add more unit tests for the effected methods.

One side effect of this change is that `zh-MO` and `zh-SG` are no
longer converted to Translate format. However, they never need to be,
since they are not possible Chrome Accept-Languages. This conversion
was copied over from language_util.cc where those variants can be
possible page-languages.


[1] https://crrev.com/c/1990476
[2] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/settings/languages_page/languages.ts;drc=0b7b63be28c0d58e996f79faf686987e52d8f20c;l=975

Bug: 1353604
Change-Id: I26057f5d6bcf9affc58cd503b66e6326a7938ddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3895251
Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Trevor Perrier <perrier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1047078}