Google Git
Sign in
chromium / chromium / src / 0332431525a242933d6534e8ef31c8ce78fb42c5
commit0332431525a242933d6534e8ef31c8ce78fb42c5[log] [tgz]
authorDavid Benjamin <davidben@chromium.org>Wed Dec 13 00:10:51 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Dec 13 00:10:51 2023
tree7cec6a2c8bfda2a7fff060ff7a0be631aa7c3a26
parent87bf52430377c856d881dc1cd973732962c8b6b4 [diff]
Default initialize all fields of PartialTranslateRequest

The unit tests create a PartialTranslateRequest without filling in all
the fields. This is fine for the string types, which are default,
initialized, but bool is not. Default-initialize everything, so we don't
need to risk problems with uninitialized fields.

This fixes the following UBSan error:
https://luci-milo.appspot.com/ui/inv/build-8761892290068215089/test-results?q=PartialTranslateManagerTest.CreateResponse&sortby=&groupby=

While I'm here, I noticed an unnecessary copy of
PartialTranslateRequest. Fix that by using a const reference.

Bug: 1394755
Change-Id: I100441f28b2266afa22f546c01e258c3c2b2c51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5116946
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Reviewed-by: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1236669}
2 files changed
tree: 7cec6a2c8bfda2a7fff060ff7a0be631aa7c3a26
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.