Google Git
Sign in
chromium / chromium / src / 033bf07f05b7503d016a802e51b53ccfb57e8990
commit033bf07f05b7503d016a802e51b53ccfb57e8990[log] [tgz]
authorSylvain Defresne <sdefresne@chromium.org>Thu Apr 17 10:46:04 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 17 10:46:04 2025
treee8c69ae76a8c5686e0ff548fe7544450e9cf95ad
parenta46c32927298e8604e91eef8024653e67c7dbed5 [diff]
[ios] Fix dependencies of omnibox_icon_type_constants target

With https://crrev.com/c/6458600 the omnibox_icon_type_constants
is bringing dependencies on //ios/chrome/browser/omnibox/public
and many more targets that depends on the provider.

This causes linking error with EarlGrey tests that use the target
as the EarlGrey test modules are not allowed to link with the
provider target (nor with most of //ios/chrome/browser code).

Previously the target containing omnibox_icon_type.{h,mm} was a
distinct target to allow bringing the minimum amount of code into
EarlGrey but after the change it was moved into a much larger one.

Fix this by moving the two files in the "constants" targat that is
designed for use by EarlGrey. Copy the comment that was above the
old omnibox_icon_type_constants target to remind developers and
reviewers that this target should have the minimum number of deps
possible.

Bug: none
Change-Id: I0eea1ce07251717c475578fca21af7a48b63873e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6468396
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Ameur Hosni <ameurhosni@google.com>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ameur Hosni <ameurhosni@google.com>
Cr-Commit-Position: refs/heads/main@{#1448235}
2 files changed
tree: e8c69ae76a8c5686e0ff548fe7544450e9cf95ad
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.