Google Git
Sign in
chromium / chromium / src / 03484499ff302c4ef5463477518ac95b74a03646
commit03484499ff302c4ef5463477518ac95b74a03646[log] [tgz]
authorVarun Khaneja <vakh@chromium.org>Tue Aug 14 19:19:39 2018
committerCommit Bot <commit-bot@chromium.org>Tue Aug 14 19:19:39 2018
tree6508dc1ce96da4073e2ba04eadea7d72c13baf53
parent68b4d2e190a0c62890099b7953bf26d9d131cebd [diff]
Safe Browsing: Remove code for PVer3. It's time!

PVer3 is the old specification of the protocol to download blacklist
updates and query full hashes from the Safe Browsing service.
PVer4 replaced this code in crbug.com/543161

Overall changes:
* Replaced the use of SafeBrowsingProtocolConfig with V4ProtocolConfig.
* Made TestSafeBrowsingService() the base class for a all derivatives of SafeBrowsingService in tests.
* Add CanCreateDatabaseManager and CreateDatabaseManager in ServicesDelegate::ServicesCreator
  to allow tests to create their own DatabaseManager, if they choose to.

TBR=tnagel
TBR'ing tnagel since the changes in annotations.xml are trivial: just deleting lines for files being deleted.

***************
Note to Sheriff
***************
If this CL breaks any builds or any tests, please feel free to revert immediately.

Reviewers, please review the changes in the following files:
rdevlin.cronin: chrome/browser/extensions/
ntfschr: android_webview/browser/aw_safe_browsing_ui_manager.cc
davidben: chrome/browser/net/trial_comparison_cert_verifier_unittest.cc, chrome/browser/prerender/prerender_test_utils.cc
tnagel: tools/traffic_annotation/summary/annotations.xml
qinmin: chrome/browser/download/download_browsertest.cc
bbudge: chrome/test/ppapi/ppapi_filechooser_browsertest.cc

Bug: 754341
Change-Id: I889dfe42848b8579e26aed0ea92c86b38fdfb87a
Reviewed-on: https://chromium-review.googlesource.com/1153969
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582991}
64 files changed
tree: 6508dc1ce96da4073e2ba04eadea7d72c13baf53
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .