| commit | 0373fe1947fb05fbe421407dc7f393e430db6019 | [log] [tgz] |
|---|---|---|
| author | aelias <aelias@chromium.org> | Tue Feb 21 23:50:54 2017 |
| committer | Commit bot <commit-bot@chromium.org> | Tue Feb 21 23:50:54 2017 |
| tree | 6f8968fc428e17a6e2c70847d31070c1bdb6b7c8 | |
| parent | 680838dbb7a482010ffa8c686245ddc2de024e45 [diff] |
Revert of Add PrefStore::GetValues (patchset #8 id:140001 of https://codereview.chromium.org/2692203007/ ) Reason for revert: Breaks compile on Cronet proxy. BUG=694814 Original issue's description: > Add PrefStore::GetValues > > Currently there's no way to proxy a PrefStore, which we need to > in the new prefs service, because there's no way to get its > initial state. The existing observer interface can only be used > to get changed values and GetValue requires that you know all the > keys in advance. > > GetValues involve a deep copy, but the intended consumer needs to > take ownership to send the value over the wire anyway. > > Design doc: https://docs.google.com/document/d/1Fj013SXClTzk4Yfq2eoL9OkKfN0h-GLXPAokCXFkcTY/edit?usp=sharing > > BUG=654988 > > Review-Url: https://codereview.chromium.org/2692203007 > Cr-Commit-Position: refs/heads/master@{#451691} > Committed: https://chromium.googlesource.com/chromium/src/+/311d4a192239299e42e66b1319b19ee58a5a4b06 TBR=sammc@chromium.org,emaxx@chromium.org,bauerb@chromium.org,tibell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=654988 Review-Url: https://codereview.chromium.org/2704133006 Cr-Commit-Position: refs/heads/master@{#451856}