[Autofill] Move RationalizeAndAssignSections() out of DetermineHeuristicTypes() This CL moves RationalizeAndAssignSections() out of DetermineHeuristicTypes() and adds the necessary calls of RationalizeAndAssignSections(). The motivation for this change is that DetermineHeuristicTypes() will become a free function and operate on FormData instead of FormStructure. RationalizeAndAssignSections() will remain a member function of FormStructure because it needs access to several members of AutofillField. RationalizeAndAssignSections() is relatively cheap and is called on the UI thread in OnLoadedServerPredictions() already. The CL was produced by joining lines of DetermineHeuristicTypes() calls and then applying the following substitution: %s/\(\s*\)\(\S*\(->\|\.\)\)DetermineHeuristicTypes(\(\S\+\), \(\S\+\), \(\S\+\));/\0\r\1\2RationalizeAndAssignSections(\4, \5, \6); Bug: 427787155, 40232021 Change-Id: I4c0f1a167f0795b044811c7b9e04515205a1a88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6902838 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by: Jan Keitel <jkeitel@google.com> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/main@{#1509491}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.