Google Git
Sign in
chromium / chromium / src / 03d93ff0c5a63d8ff85d4fc946b4cb41ce5b5fc0
commit03d93ff0c5a63d8ff85d4fc946b4cb41ce5b5fc0[log] [tgz]
authorShunya Shishido <sisidovski@chromium.org>Fri Nov 01 20:11:44 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Nov 01 20:11:44 2024
tree5f84bf0d758b1e14415625543e831f288f1e1e60
parent67dcaebc869b183055d430269b128ef2a239ea1e [diff]
Stop sending unnecessary subresource requests with Static Routing API

This is a bug fix CL.

Before this CL, there are unnecessary network requests triggered from
SWSubresourceLoader. This is occurred when
`race-network-and-fetch-handler` is specified for the main resource
load, and there are no matched router rules for subresource.

This information is passed to the the renderer via
`fetch_handler_bypass_option`, which is retrieved through
`controller_connector_` in SWSubresourceLoader.

When `race-network-and-fetch-handler` is specified and the network
request is dispatched,
`ServiceWorkerFetchHandlerBypassOption::kRaceNetworkRequest` is set to
fetch_handler_bypass_option, and the subresource loader also starts the
network request without checking other conditions.

I believe this is the bug introduced when we add the
BestEffortServiceWorker behavior to the static routing API. We don't
explore BestEffortServiceWorker anymore and it was taken over by
SWAutoPreload. We can safely remove code triggering the network request
in the resource loader.


Bug: 376723182
Change-Id: Ifda20a2ab8c60dd8dc7cdb286d1440cf0766f684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5981616
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Keita Suzuki <suzukikeita@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1377047}
2 files changed
tree: 5f84bf0d758b1e14415625543e831f288f1e1e60
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.