Google Git
Sign in
chromium / chromium / src / 048ff3d2b46c1bf52b5b2fad6a464becab8cee6d
commit048ff3d2b46c1bf52b5b2fad6a464becab8cee6d[log] [tgz]
authorChris Lu <thegreenfrog@chromium.org>Wed Jun 15 12:04:59 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 15 12:04:59 2022
treeeb8b03e374631f7776c3c6191423428c1f0933ee
parent204f7600e2321352b5fc0ca29d7e2e398e9a708d [diff]
[ios] Fix Most Visited Tiles bugs

This change fixes two things. One, if a user removes the last MVTile,
the entire Most Visited Tiles StackView must be removed. Otherwise, it
will take up vertical space and push out the Shortcuts. Second,
reloadAllData always re-initializes |parentItem| and that therefore
creates a mismatch between the referenced parentItem passed to
ContentSuggestionsFaviconMediator's API and the latest object. This is
a problem since reloadAllData is called right after calling
fetchFaviconForMostVisited:parentItem: Thus,
ContentSuggestionsFaviconMediator's calls to the ViewController
to update |parentItem| will do nothing because of that mismatch.

(cherry picked from commit 006ebd021d167305efa723f2e9a3b4dfce28ae50)

Bug: 1316991, 1335085
Change-Id: I62a3015ce0ef6ea81b3e55a587f42232a44a7eba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3698550
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1013207}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3705818
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Harry Souders <harrysouders@google.com>
Cr-Commit-Position: refs/branch-heads/5060@{#865}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
2 files changed
tree: eb8b03e374631f7776c3c6191423428c1f0933ee
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.