commit | 04c11066d7979bd89ffa236ba8aa253aadada8df | [log] [tgz] |
---|---|---|
author | EmiliaPaz <emiliapaz@chromium.org> | Fri Apr 26 01:19:11 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Apr 26 01:19:11 2024 |
tree | cdcc8cc9e4fbd74042c12a1801aa6f9f4af15dd1 | |
parent | a7a239c12d93b9b7831a058ec1d86a039bed9e7d [diff] |
[Extensions c2s] Show site access requests in menu iff they are added Site access requests are currently shown in the menu for all extensions that have site access withheld (and not only request activeTab permission). Instead, they should only be shown iff a site access request was explicitly added. Thus, this CL adds observers for OnSiteAccessRequestAdded() and OnSiteAccessRequestRemoved() to update the menu based on the existent requests. This required updating test to reflect the new behavior. Note: requests will no longer be visible in the menu, since we have not implemented yet the API that allows extensions to add requests. Bug: 330588494 Change-Id: If3c5c96e2a3a6c68964f56cbc2be24ad29a37dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5475231 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: Emilia Paz <emiliapaz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1292814}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.