commit 04cd454a8be89043167d9cf091c9dbece279a7ee
author Khalid Peer <khalidpeer@chromium.org> Mon Mar 11 21:36:41 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 11 21:36:41 2024
tree 93d9992b4eeed2b0430f870cb537271f35c3156c
parent e9a1829f96d19ac8b3e198fa5e53586134b00efa

[omnibox][ml] Fix edge-case with linear-mapped scoring of doc suggest.

When enabling one of the linear-mapped scoring variants (conservative,
moderate, or aggressive), it looks like the existing implementation of
ML scoring will naively assign a final score of "min + ml_score * (max
- min)". However, this means that stale suggestions sourced from the
DocumentProvider cache, which normally have a traditional score of zero,
would be assigned a non-zero relevance score and thus get surfaced to
the user via the Omnibox popup.

Since this results in a subpar user experience (see screenshots), this
CL fixes this behavior by ensuring that we don't score any stale
suggestions using the linear-mapped ML scoring variant. This ensures
that users do not see any DocumentProvider suggestions which are
irrelevant with respect to the current Omnibox input.

BEFORE: http://screen/3zK25nppxkhdCYb
AFTER: http://screen/9RepjgfFSjmt8Fi

Bug: 40062540
Change-Id: I11389dda9602fda2ca0f0ead945bcd2cd446cfa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5342743
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Khalid Peer <khalidpeer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1271191}