commit 05136415f6d7b51a7ada8a5b8cb769352b5113db
author Scott Yoder <scottyoder@google.com> Sat Dec 09 00:00:49 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Dec 09 00:00:49 2023
tree 1a2aaa6c3063990d9f4f0b8d50ce4bd83e807aaa
parent 8e97f2715cbb131dffcf7b4eee5f97bcdefa9f27

[ios] Fix overscroll actions animation

The animation that happens as the overscroll actions view is going away
appeared to be especially abrupt and glitchy on the NTP. After some
investigation, it appears that the "header inset" (the content offset
in the parent ScrollView where the overscroll view is placed) was being
used incorrectly in this animation. On the NTP, the top of the parent
ScrollView's content is not offset zero, it is somewhere in the
neighborhood of -550px because the top of the feed is always offset
zero. This is wildly different than a "normal" WebKit view and resulted
in a very short glitchy animation.

In both the NTP and WebKit view cases, the added offset was causing the
animation to not really complete. For example, as the offset nears zero
the reload icon should rotate CCW as it disappears and the New Tab and
Close icons slide towards the center. This part of the animation was
lost (completely on the NTP, partially on WebKit views) because of the
offset and it really just slid up off screen and faded out. This offset
may have been added with the introduction of the notched iPhone which
resulted in an additional offset at the top of the screen.

Additionally, the parent view was not animating its slide back up into
position as it appeared the code was trying to do. This was fixed by
changing the setContentOffset:animated: to instead use a UIView
animation which included both the contentOffset and the contentInset,
resulting in a smooth slide back up into position.

Existing animation:
https://drive.google.com/file/d/1miStOXWKHbALJP8-00KnZbtzJhL5PQiT/view?usp=sharing

Fixed animation:
https://drive.google.com/file/d/1KIv_Y0rwEl0UGRxrZrwzscKvnAu6fC36/view?usp=sharing

Fixed: 1502218
Change-Id: Ia163697fcc9190f983be1226d976928ceed42b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5105628
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Scott Yoder <scottyoder@google.com>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1235315}