Google Git
Sign in
chromium / chromium / src / 052519c85371d865059de7aa3e155da201942d8d
commit052519c85371d865059de7aa3e155da201942d8d[log] [tgz]
authorAlex Chen <alexwchen@chromium.org>Tue Jan 14 17:00:57 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 14 17:00:57 2025
tree5d245e6408ec0501b25af390eafd02c3a9213255
parent058b0781f13c79d4b21c7def271a2b5511ce36f2 [diff]
[omnibox][spark] Use policy set icon for aggregator keyword matches

Currently, the icon URL for a search aggregator is not persisted. As
a result, whenever a user uses a search aggregator and navigates to the
destination URL, the icon URL of the favicon is updated automatically
to the destination page's favicon. Since the icon URL for a search
aggregator should only be set by policy, this change updates the
TemplateURLService to exclude search aggregator TemplateURLs from
typical favicon updating.

As a result, keyword matches will render the policy set icon for
aggregator keywords. If no icon URL is set, the default globe icon
will be shown.

Note: Currently, only icons hosted on a page that has been navigated to
will show in the keyword match. Otherwise, the default globe icon
is shown. A later CL will handle fetching the favicon without
navigation.

Screenshot of no icon set by policy/not navigated to icon URL:
https://screenshot.googleplex.com/3H75GT6yopxp2yt

Screenshot of icon set/navigated to:
https://screenshot.googleplex.com/ARQ4R5iZrZX47Xm

Bug: b:380509200
Change-Id: Ia65207154a2fdc73b2a9fc3c4418fc7d504f973c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6142954
Commit-Queue: Alex Chen <alexwchen@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1406135}
2 files changed
tree: 5d245e6408ec0501b25af390eafd02c3a9213255
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.