Google Git
Sign in
chromium / chromium / src / 0555626c8333e99afc31829c43e506c8da1048a3
commit0555626c8333e99afc31829c43e506c8da1048a3[log] [tgz]
authorCharlie Reis <creis@chromium.org>Thu Apr 25 21:30:49 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 25 21:30:49 2024
tree5dd3f6f1ef8b604d7a2ea1d7b1d2aa939b6aa81f
parent85e14d8f63597aa97ab43e0fa0362839fdfeb552 [diff]
Allow LoadDataWithBaseURL to call document.open on same-origin frames.

This was causing new restrictions in CanCommitURL to fail on Android
WebView, when a pseudoscheme (with an opaque origin) tried to call
document.open or document.write on a same-origin about:blank frame,
causing it to inherit the illegal URL.

This CL fixes the problem by bypassing the relevant checks for all
documents in the origin of a LoadDataWithBaseURL document, as long as
that origin is opaque. Non-opaque origins have not been causing similar
problems, and we do not want actual content loaded from such origins to
bypass the same checks.

Bug: 326250356, 324934416
Change-Id: I1b01cc3972a43bcdafe0501bd82c17bf97ed82f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410353
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292708}
4 files changed
tree: 5dd3f6f1ef8b604d7a2ea1d7b1d2aa939b6aa81f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.