Fix tinting of bottom bar button icons.

This CL fixes two issues with tinting of bottom bar button icons:

1. The tint colour was not chosen in the same way the top bar icon tint colour was chosen, which could lead to inconsistent colour on top and bottom bars. See e.g.:

Before:  https://screenshot.googleplex.com/9twp6KJjn9qNCR9.
After: https://screenshot.googleplex.com/ALYzjx98xgxAJCS

2. A side-effect of (1) was that the tint was not chosen based on whether the embedder-provided background colour was dark or light, but rather based on whether the current theme was dark or light. This could lead to cases like this, where e.g. embedder has provided a lighter colour for dark theme:

Before: https://screenshot.googleplex.com/kptHgDvYcD4yjek.
After: https://screenshot.googleplex.com/6XCojfCTXsYuRTf

Bug: 381508007
Change-Id: I144635f40b9fdf0c3a7725d9ccc52c799ae12811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6054788
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Edmund Wright <edmundw@google.com>
Auto-Submit: Edmund Wright <edmundw@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Theresa Sullivan <twellington@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1391107}
5 files changed
tree: ac97afdaf0676def2db758a343e217c3acc8bdcc
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.