Google Git
Sign in
chromium / chromium / src / 0580ff9c72be98ba8c06fbcaa391a11f258e6f75
commit0580ff9c72be98ba8c06fbcaa391a11f258e6f75[log] [tgz]
authorFergal Daly <fergal@chromium.org>Wed Nov 27 06:07:13 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Nov 27 06:07:13 2024
treec53191b66a5e02815c1b8b1b10af7f648af8b357
parentb2def42b437221c5b6a73c1c8ccbcab6d7cf2983 [diff]
Tighten up the language_detection core component.

Components should only depend on other components or code that nothing
else can link against. Otherwise we can end up with second copies of
supposed singletons.

This change
- makes everything external depend on "/core" instead of "/core:language_detection"
- correctly annotates the exports we want and moves them into the `component()`
- leaves the rest of the code in "/core:internals" so that the
  unittests can test it without needing to export it

It still leaves some non-component deps but I don't think they are
causing a problem.

Bug: 380786760,354069716

Change-Id: Iefb86f793df6f65ebac633073d9ef508de13e93a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6047209
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Trevor Perrier <perrier@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1388641}
12 files changed
tree: c53191b66a5e02815c1b8b1b10af7f648af8b357
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.