Google Git
Sign in
chromium / chromium / src / 0584c1805c005f1aac35c28c6738d9a2455a876c
commit0584c1805c005f1aac35c28c6738d9a2455a876c[log] [tgz]
authorXianzhu Wang <wangxianzhu@chromium.org>Mon Feb 10 20:54:14 2020
committerCommit Bot <commit-bot@chromium.org>Mon Feb 10 20:54:14 2020
tree82fed6b092f0a40360f3b4d56cf797560290b3a3
parent1e941aa74dc7dd7a7006ba7c0de69f8cf98958dd [diff]
Disable optimization for objects painting nothing

The optimization is to avoid paint invalidation for objects that will
nothing. It was important before we have separate raster invalidation.
Now it might be less important because these paint invalidation won't
cause raster invalidation which is based on painted result.

Will revert this CL if the regression is not acceptable. Otherwise
will remove the dead code for these optimizations.

Cluster-telemetry [1] shows that this CL will not affect record time in
the benchmark because this CL only affects paint invalidation which is
not measured by the benchmark. Will see how this CL affect real-world
PrePaint and Paint performance after it is landed.

[1] https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-ChromiumPerf-4638/html/index.html

Bug: 1049440
Change-Id: I79481036dc3f4ada31093aa1f525606ce17bb56d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042262
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
6 files changed
tree: 82fed6b092f0a40360f3b4d56cf797560290b3a3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .