Google Git
Sign in
chromium / chromium / src / 059665460ca95cb7e74abe5f4b585ecbd0f94c9f
commit059665460ca95cb7e74abe5f4b585ecbd0f94c9f[log] [tgz]
authorRakina Zata Amni <rakina@chromium.org>Thu Jan 07 07:21:50 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jan 07 07:21:50 2021
tree97c5fb436880a933e37261a021b4853d7a9554df
parent60ae5b812d3c2a1ccd54fb201164db90609db4b8 [diff]
Track multiple pending same-document NavigationRequests in RFHI

Currently we only track the latest same-document NavigationRequest in
RFHI, so if a new browser-initiated same-document navigation got into
the commit stage before an older  browser-initiated same-document
navigation's DidCommit IPC gets processed, we'll delete the older
NavigationRequest and re-create the NavigationRequest later with
NavigationRequest::CreateForCommit, which incorrectly assumes that it's
for a renderer-initiated same-document navigation, getting the wrong
values for browser-initiated navigations-related attributes such as
intended_as_new_entry and nav_entry_id.

Bug: 1155414, 1133115
Change-Id: I4d4658d34982f1bb895d6b3dba497bbc6db7341c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599677
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840956}
4 files changed
tree: 97c5fb436880a933e37261a021b4853d7a9554df
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.