Abort all MultiBufferDataSource before deleting The previous teardown logic only aborted MultiBufferDataSource implementations which were waiting for an outstanding read to complete, but MultiBufferDataSource will continue to update it's buffers in the background even after a read is completed. Because these MBDS instances were still downloading without being aborted, the deletion of BufferedDataSourceHostImpl was causing a UAF. Bug: 1478104 Change-Id: If6318b478f4da0c9f83e9653e0031837805a70b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4898498 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted (Chromium) Meyer <tmathmeyer@chromium.org> Auto-Submit: Ted (Chromium) Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/main@{#1202958}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.