| commit | 0622342f0a331e79c90bc060fe7916c86d0640a3 | [log] [tgz] |
|---|---|---|
| author | Caleb Raitto <caraitto@chromium.org> | Thu Mar 09 19:57:39 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 09 19:57:39 2023 |
| tree | d9c16a479d0d5d0afca4985e407189e4eee9ca16 | |
| parent | 43c9442aad268f2791887595c535292e0b6b7f8a [diff] |
Revert "Fix enum conventions and forward compatibility" This reverts commit 9d2b56359e356d8a18473f28a44d7f84d1899b2d. Reason for revert: Seems to have introduced flaky test, see https://chromium-review.googlesource.com/c/chromium/src/+/4320910?attempt=3&checksRunsSelected=linux-lacros-rel,linux-rel&tab=checks Original change's description: > Fix enum conventions and forward compatibility > > "enum" in WebIDL doesn't allow unknown enum values when enums are used > as method parameters, but this makes forward compatibility difficult. > Switch to manually checking USVString values instead. > > Also, support the correct "naming-convention" and add a use counter for > the deprecated "camelCase" convention so that we safely remove support > in a future release. As part of this, add UMA metrics on usage (UMA is > used instead of use counters since would require a fair amount of > complicated plumbing and lifetime concerns in the update code, since the > RenderFrameHost is required to update the count). > > Bug: 1422002 > Change-Id: I661fc52654804fac1cbb51ff24248e3df3d14bae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317804 > Commit-Queue: Caleb Raitto <caraitto@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: David Schinazi <dschinazi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1115196} Bug: 1422002 Change-Id: Idf37ca3162cf6fdc8612add194b391865b481311 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4324741 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: David Schinazi <dschinazi@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/main@{#1115292}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.