commit | 068c715e29ebcf5ce38d09fa786cf4beb2f35054 | [log] [tgz] |
---|---|---|
author | Ben Pastene <bpastene@chromium.org> | Tue Apr 02 23:31:44 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Apr 02 23:31:44 2024 |
tree | 435a21df2c91cd66f4925cb6c43f0999b6b55b87 | |
parent | 3c5f8db4f08b667b7db5f6d958211b8fedb4fc81 [diff] |
Reland "mb: Allow custom build dirs for the isolate-everything run mode" This is a reland of commit 75004f6b767c69f166011a3aec6ca0d3b6ec69f8 Reland fix: register the "--write-ide-json" arg with isolate-everything's arg parser Verified fix locally with invocation: ./tools/mb/mb.py isolate-everything -m chromium.linux -b 'Deterministic Linux' out/Release This should avoid errors like: https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux/46722/infra Original change's description: > mb: Allow custom build dirs for the isolate-everything run mode > > "GetConfig()" mostly just wraps "Lookup()", but is smart enough to > gracefully re-use a pre-existing build dir. This can be leveraged by > the UTR in instances where the UTR hasn't used mb.py to gen. > Practically that's: > - when the user skips "compile" mode > - when the user overrides with some custom GN args > > So this allows "mb.py isolate-everything" to be used in both of those > cases by preventing it from over-writing the local build dir. > > Bug: 41492686 > Change-Id: I150672865d5cc333b946603cac61716281f643a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5411040 > Reviewed-by: Struan Shrimpton <sshrimp@google.com> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1281261} Bug: 41492686 Change-Id: I0459ec6b0c8cce7fc181d38698747fb8ca4b32eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5416435 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Struan Shrimpton <sshrimp@google.com> Cr-Commit-Position: refs/heads/main@{#1281541}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.