commit | 06b3364e626062b3c12b6a70332a79eb2f55f0b4 | [log] [tgz] |
---|---|---|
author | Tina Wang <tinazwang@google.com> | Tue May 24 01:30:31 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue May 24 01:30:31 2022 |
tree | 3fd9988d0ddb71cc9d23f6aabd41224e1bcd6979 | |
parent | 4fa8bdae69d3f681ffc95d82a9c8f8fcb21d2d72 [diff] |
[WebChannels] Fix crash when open overflow/popup menu in incognito The DiscoverFeedService is started when luanch chrome, but it is only for non-incognito browser. When calling from an incognito browser, it can't get the correct instance as well as the metrics recorder. This cl checks if the users are browsing in incognito before setting the feed metrics recoder to the 3-dot menu. (cherry picked from commit 29e66bd5f79cb1d7c98d7f6f3846883d137aeb1e) Bug: 1327006 Change-Id: I43c60123de5c4766ff78a3530be6981ea599245c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645584 Reviewed-by: Adam Arcaro <adamta@google.com> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1005901} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3661703 Auto-Submit: Tina Wang <tinazwang@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/branch-heads/5060@{#212} Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.