commit | 06b6ad1cee45a627b53c9abb745f818f1caf8bda | [log] [tgz] |
---|---|---|
author | Vladimir Levin <vmpstr@chromium.org> | Fri Oct 22 06:00:19 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Oct 22 06:00:19 2021 |
tree | c148b36e38c644636adcd4b5e66f6407af46a8b6 | |
parent | 25f8d9f2d8d4b55d1bc660bc43789565e181ce7e [diff] |
AX: Fix mac zoom-for-dsf accessibility hit testing. This patch addresses the wrong hittesting as a result of zoom-for-dsf. 1. The hit testing point is always converted to physical space since it is always given in DIPs (regardless of zoom for dsf). 2. GetViewBoundsInScreenSpace now returns "blink space" coordinates, meaning physical if zoom-for-dsf is on and DIPs otherwise. 3. The result of GetBounds is adjusted to DIPs if zoom-for-dsf is on, since it returns "blink space" coordinates. I left a few TODOs which I plan to address after this issue is fixed. I believe that we should have consistent non-blink spaces in this area of the code, so it's easier to reason about (and so we can limit the IsUseZoomForDSFEnabled checks to only a few locations) R=kbabbitt@microsoft.com, dlibby@microsoft.com, aleventhal@chromium.org Fixed: 1234108 AX-Relnotes: n/a. Change-Id: I73f38087b58e692e3d67a82651950847cc122432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3234860 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/main@{#934153}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.