commit 06deca59d48cd7f78022cfe35483a642e728c49c
author Simon Hangl <simonha@google.com> Tue Sep 19 08:09:49 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Sep 19 08:09:49 2023
tree cee642b5fce2a462bd83c398b1cf65a586a881bc
parent bfefb527ce7b1e4eb5dbe46c04e7d98c53c2abd1

Fix dangling ptr on shutdown in WithSharedWebContentsResources

In a recent CL [1] the web contents manager prepares the shared web
contents for loading before the command starts. This required
the `start_command` callback (which implicitly captures the lock and
therefore a `raw_ref` to the shared web contents; captured to the
callback in `WebAppLockManager::AcquireLock`) to be moved to the URL
loader.

The preparation, done in the `WebAppUrlLoader::PrepareForLoad`
function, posts a loader task in `WebAppUrlLoader::LoadUrlInternal`.
If the system shuts down at this point, this will lead to a dangling
pointer in `WithSharedWebContentsResources`. This was discovered
by porting an existing test the externally managed app refactoring
[2].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/4825046
[2] https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/b8769589932351133825/test-results?q=ExactID%3Aninja%3A%2F%2Fchrome%2Ftest%3Abrowser_tests%2FExternallyManagedAppManagerBrowserTest.ShutdownWithPendingInstallation+VHash%3Ac7218831f14d758b&clean=&sortby=&groupby=

Change-Id: I4ec61602abf4cbfaad9392982a4fa17265ada717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4875373
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Simon Hangl <simonha@google.com>
Cr-Commit-Position: refs/heads/main@{#1198239}