commit 072051bde5425e93aae2cd23944d4e4751d89004
author Sebastien Marchand <sebmarchand@chromium.org> Fri Jul 30 17:59:53 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 30 17:59:53 2021
tree 3d8b64603c4d125e061e2e7262f625f0a7ba7365
parent 9fd2e7d4d15945dca2e4f703071177a179709142

Reland "Fix the reporting of CPU time from the  coalition data and add tests"

This reverts commit 743ef0b79324aeffea4b3a756d36a029302b042c.

Reason for revert: Removed the source of flakiness. Simply check that
the CPU usage isn't null during a given interval rather than checking if
it exceeds a given value as this doesn't work well on all systems.

See PS1..3 for the diff from the original CL.

Original change's description:
> Revert "Fix the reporting of CPU time from the  coalition data and add tests"
>
> This reverts commit e92b870db77adf077e03dc45a884bdd7d21b8cf4.
>
> Reason for revert: mac-arm64-rel-tests is failing, starting with build 2844.
>
> https://ci.chromium.org/ui/p/chromium/builders/ci/mac-arm64-rel-tests/2844/overview
>
> [ RUN      ] ResourceCoalitionTests.Basics
> ../../chrome/browser/performance_monitor/resource_coalition_mac_unittest.mm:49: Failure
> Expected: (sample->cpu_time_per_second) >= (0.2), actual: 0.0913336 vs 0.2
>
>
> Original change's description:
> > Fix the reporting of CPU time from the  coalition data and add tests
> >
> > The CPU and GPU time were not reported properly from the coalition data,
> > the computation that converts the time samples in {cpu time / sec} are
> > not right.
> >
> > Also, some metrics were still emitted with a "milli" suffix, this has
> > been removed.
> >
> > Tests have been added to prevent this kind of mistake.
> >
> > Bug: 1229884
> > Change-Id: I7b5478ac6c323dbced28da9eb47dc0df296dd49c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3058615
> > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#906831}
>
> Bug: 1229884
> Change-Id: I1039d870622b7c33a3d83721365acffd55b257ca
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3062200
> Auto-Submit: Avi Drissman <avi@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
> Owners-Override: Luciano Pacheco <lucmult@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#906968}

Bug: 1229884
Change-Id: I67a14ffdae1fe6e230532fa77e8134cc09864cf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3063359
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#907170}