commit 074d78cccf50461c0d3e8cbba07c0d681f6415d8
author Christoph Schwering <schwering@google.com> Mon Mar 10 19:36:19 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 10 19:36:19 2025
tree b33e9cca2217867cdd5adcfd7573218507c8fddf
parent 3266c6f9a1a3cc63114669282a7d6a2119766e39

[Autofill] Remove IsCheckable() from SameFieldAs()

IsCheckable(check_status()) is true iff
(1) the element is not checked and
(2) HTMLFormControlElement::FormControlType() is neither
    kInputCheckbox nor kInputRadio.

Under normal circumstances:
(a) (2) implies (1).
    This does not hold to <input type=text checked>, but it's
    arguably a bug that FormFieldData::check_status() claims that
    such fields are checkable.
(b) (2) implies FormFieldData::form_control_type() is kInputCheckbox
    or kInputRadio.
    This does not hold the HTMLFormControlElement has ever been
    kInputPassword in the past because Autofill generally treats the
    kInputPassword as sticky.

So under normal circumstances, equality of
FormFieldData::form_control_type() implies equality of
IsCheckable(check_status()) and therefore  this CL preserves
equivalence.

Since FormFieldData::SameFieldAs() is merely a very rough equality
check, we don't need consider the case (a) and (b). In any case, the
behaviour change in case (a) is clearly a bug fix, and the
behaviour change in case (b) is in line with the rest of Autofill and
Password Manager, which treats kInputPassword as sticky.

Bug: 40183094, 402071086
Change-Id: Ic8e0cf26d492d31b746f11216f9453b081f02cd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6329635
Reviewed-by: Jihad Hanna <jihadghanna@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#1430413}