Google Git
Sign in
chromium / chromium / src / 078d9f4e633bf9d6fa6f8314a057d703d30fb519
commit078d9f4e633bf9d6fa6f8314a057d703d30fb519[log] [tgz]
authorMikel Astiz <mastiz@chromium.org>Wed Dec 15 11:59:14 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Dec 15 11:59:14 2021
tree123f88f335ebbe1e06483a1580597bfd9b03b507
parent7b06ca76362e9e3d497060981d9219376282fa4d [diff]
Reland "[Passwords] Fix assertion failure when opening password settings"

This is a reland of 293ef66ce69d271b8ff9288c6f0598688270ed0b, updated
to avoid breaking PasswordSettingsTest#testManageAccountLinkSyncing()
by making sure the test mimics sync having been fully initialized.

Original change's description:
> [Passwords] Fix assertion failure when opening password settings
>
> Method SyncService.isUsingExplicitPassphrase() has the precondition that
> the sync engine must have initialized, as per isEngineInitialized(). To
> avoiding running into assertion failures, PasswordManagerHelper must
> first rule out ongoing initialization before invoking
> isUsingExplicitPassphrase().
>
> Change-Id: I8f519953c6d37aa4d9d54e6b043c24054fb46b45
> Fixed: 1276532
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336879
> Reviewed-by: Ioana Pandele <ioanap@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#951464}

Change-Id: I280c58064ba674e1573c938002bdb301fc5d6533
Fixed: 1276532, 1279940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341531
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#951898}
3 files changed
tree: 123f88f335ebbe1e06483a1580597bfd9b03b507
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.