[MagicStack] Change magic stack module names.
This CL modifies the names of modules in both the settings page and the name used for hiding modules according to this doc: https://docs.google.com/document/d/1-ds7JpgIYpv0r5hSaEr2x_WbfP67lIWNsZD-xwUQsb8/edit?usp=sharing
The following are the screenshots after changing the names:
Price change module name:
https://drive.google.com/file/d/1G0FfZbnBVtC6k4thpUViIJCc7_NYutxQ/view?usp=sharing&resourcekey=0-hUuahWL9fSOXa7dTdAvi4Q
Context menu hide name for tab resumption module:
https://drive.google.com/file/d/1iCYBc8zZGyOt6j3-tbZOvb9lmUeI2lIM/view?usp=drive_link&resourcekey=0-7EfbfbTB0LG_zh4QaX_14Q
Context menu hide name for price drop module:
https://drive.google.com/file/d/18jt0hAjb2xPxvnv9vcY2AAxiEG8kdMlh/view?usp=sharing&resourcekey=0-ngn6miKfcULbpvLi3_TGdA
Context menu hide name for safety check module:
https://drive.google.com/file/d/1FBUVipZpqGcP53QVY4pc1XOFCGjTPP8u/view?usp=drive_link&resourcekey=0-J2b9YlmV3L5MSXhkw7cdPQ
Bug: 355008918
Change-Id: I42b47126cec9546db64c7a813ee6f581b49a8f58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5739731
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Xinyi Ji <xinyiji@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1333758}
diff --git a/chrome/browser/tab_resumption/junit/src/org/chromium/chrome/browser/tab_resumption/TabResumptionModuleCoordinatorUnitTest.java b/chrome/browser/tab_resumption/junit/src/org/chromium/chrome/browser/tab_resumption/TabResumptionModuleCoordinatorUnitTest.java
index 4b6342c1..06c41ca 100644
--- a/chrome/browser/tab_resumption/junit/src/org/chromium/chrome/browser/tab_resumption/TabResumptionModuleCoordinatorUnitTest.java
+++ b/chrome/browser/tab_resumption/junit/src/org/chromium/chrome/browser/tab_resumption/TabResumptionModuleCoordinatorUnitTest.java
@@ -118,7 +118,7 @@
Assert.assertEquals(
"Continue with these tabs", mModel.get(TabResumptionModuleProperties.TITLE));
Assert.assertEquals(
- "Hide continue with these tabs",
+ "Hide continue with these tabs card",
mCoordinator.getModuleContextMenuHideText(mContext));
SuggestionBundle bundle2 = mModel.get(TabResumptionModuleProperties.SUGGESTION_BUNDLE);
@@ -139,7 +139,8 @@
Assert.assertEquals(
"Continue with this tab", mModel.get(TabResumptionModuleProperties.TITLE));
Assert.assertEquals(
- "Hide continue with this tab", mCoordinator.getModuleContextMenuHideText(mContext));
+ "Hide continue with this tab card",
+ mCoordinator.getModuleContextMenuHideText(mContext));
SuggestionBundle bundle1 = mModel.get(TabResumptionModuleProperties.SUGGESTION_BUNDLE);
Assert.assertNotNull(bundle1);
diff --git a/components/browser_ui/strings/android/browser_ui_strings.grd b/components/browser_ui/strings/android/browser_ui_strings.grd
index 81307bba..1d601eb 100644
--- a/components/browser_ui/strings/android/browser_ui_strings.grd
+++ b/components/browser_ui/strings/android/browser_ui_strings.grd
@@ -1109,10 +1109,10 @@
other {Price drops on your open tabs}}
</message>
<message name="IDS_PRICE_CHANGE_MODULE_NAME" desc="The string that is shown in settings to customize whether the price drop card should be enabled.">
- Price drop card
+ Price drops on tabs
</message>
<message name="IDS_PRICE_CHANGE_MODULE_CONTEXT_MENU_HIDE" desc="The string that is going to be part of the context menu item string to hide the price drop card.">
- Hide price drop card
+ Hide price drops on tabs card
</message>
<message name="IDS_PRICE_CHANGE_MODULE_ACCESSIBILITY_LABEL" desc="Accessibility label of the price change module that will be announced in the accessibility mode, indicating that there is a price drop on one of user's open tabs.">
Price drop on your open tab, from <ph name="OLD_PRICE">%1$s<ex>$899</ex></ph> to <ph name="NEW_PRICE">%2$s<ex>$799</ex></ph>, <ph name="PRODUCT_NAME">%3$s<ex>La Specialista Espresso Machine</ex></ph>, <ph name="DOMAIN_NAME">%4$s<ex>bestbuy.com</ex></ph>
@@ -1132,8 +1132,8 @@
</message>
<message name="IDS_HOME_MODULES_CONTEXT_MENU_HIDE_TAB" desc="The context menu item for hiding a tab module. The phrasing should reflect the number of tiles shown (1 or 2+).">
{TILE_COUNT, plural,
- =1 {Hide continue with this tab}
- other {Hide continue with these tabs}}
+ =1 {Hide continue with this tab card}
+ other {Hide continue with these tabs card}}
</message>
<message name="IDS_GO_TO_OS_SETTINGS" desc="When the user clicks on this text button, Chrome sends them to the device OS Settings. One use is the text button shown below the text 'Get alerts for price drops?', which takes the user to the Android notification settings. Another use is in the primary button of the dialog prompting the user to create a device lock, which takes the user to the Android security settings.">
@@ -1145,7 +1145,7 @@
Safety Check
</message>
<message name="IDS_SAFETY_HUB_MAGIC_STACK_HIDE_TEXT" desc="Text that appears in the context menu when the Safety Check Magic Stack cards are long pressed. Hides and disables dhe Safety Check Magic Stack module when pressed.">
- Hide Safety Check
+ Hide Safety Check card
</message>
<message name="IDS_SAFETY_HUB_MAGIC_STACK_NOTIFICATIONS_TITLE" desc="Title for the notification review Safety Check module on the Magic Stack. Shown when Safety Check has identified several sites that sent lots of notifications.">
Stop lots of notifications
diff --git a/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_HOME_MODULES_CONTEXT_MENU_HIDE_TAB.png.sha1 b/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_HOME_MODULES_CONTEXT_MENU_HIDE_TAB.png.sha1
index c105f6b..d59109d 100644
--- a/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_HOME_MODULES_CONTEXT_MENU_HIDE_TAB.png.sha1
+++ b/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_HOME_MODULES_CONTEXT_MENU_HIDE_TAB.png.sha1
@@ -1 +1 @@
-3b9026718d6f955b5479f985ba1557c9ad4b6af8
\ No newline at end of file
+747aae25bfa5a68e72bcca4426583ae7c96801c7
\ No newline at end of file
diff --git a/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_PRICE_CHANGE_MODULE_CONTEXT_MENU_HIDE.png.sha1 b/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_PRICE_CHANGE_MODULE_CONTEXT_MENU_HIDE.png.sha1
index 70d586e..cb55e68 100644
--- a/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_PRICE_CHANGE_MODULE_CONTEXT_MENU_HIDE.png.sha1
+++ b/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_PRICE_CHANGE_MODULE_CONTEXT_MENU_HIDE.png.sha1
@@ -1 +1 @@
-7e136a6dd4c8f1fce77c5f7255431d67dce879e9
\ No newline at end of file
+41367e838c1d6455c59e99b23df065bf4e1c10a3
\ No newline at end of file
diff --git a/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_PRICE_CHANGE_MODULE_NAME.png.sha1 b/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_PRICE_CHANGE_MODULE_NAME.png.sha1
index c3cc84e..36ed897 100644
--- a/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_PRICE_CHANGE_MODULE_NAME.png.sha1
+++ b/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_PRICE_CHANGE_MODULE_NAME.png.sha1
@@ -1 +1 @@
-a0bf78683e98d6e6da4d0ee6488a25f85888ca55
\ No newline at end of file
+8e6c3191ed52a1a86db66aeb16a8afa3e93c54d1
\ No newline at end of file
diff --git a/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_SAFETY_HUB_MAGIC_STACK_HIDE_TEXT.png.sha1 b/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_SAFETY_HUB_MAGIC_STACK_HIDE_TEXT.png.sha1
index 33c6210..d28b593 100644
--- a/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_SAFETY_HUB_MAGIC_STACK_HIDE_TEXT.png.sha1
+++ b/components/browser_ui/strings/android/browser_ui_strings_grd/IDS_SAFETY_HUB_MAGIC_STACK_HIDE_TEXT.png.sha1
@@ -1 +1 @@
-82218231fcaa82107480ce7362dbecfe92dcb1aa
\ No newline at end of file
+5d6a0f07e9d864a90a7093fb213ea3695c1c49c5
\ No newline at end of file
