commit | 0801480790eb63faec76fa18c751215f442f03aa | [log] [tgz] |
---|---|---|
author | Pranav Modi <pranavmodi@microsoft.com> | Wed Oct 16 04:00:04 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Oct 16 04:00:04 2024 |
tree | ad5db7753371c8235a321708d977c7e9783bd735 | |
parent | b4e7d0585f8525752faf8baad46ebe0e4064e757 [diff] |
[Editing] Double-click selects wrong range for any element styled as float. The CL addresses the bug where double click on any list item selects multiple list items when list item has floating style. When there are multiple list items and anyone is selected using double click, it selects all the list items along with the one on which double click was performed. This happens because in |ComputeInlineContentsAsBlockFlow|, float style is not considered as text segment boundary and the selection is expanded for all. Also, for other cases involving floating style on element, the selection is not as expected as selecting a float element by double click selects everything. This is fixed by removing the condition which expands the selection when the element has a floating style. Firefox has the behavior similar to what we get after the fix i.e it doesn't expand the selection for floating elements. Webkit however, seems to have the same bug as chromium expanding the selection for floating elements. Bug: 40711666 Change-Id: I408b388cfd0cb5a8213ef2c433b547376ff83367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5842631 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Pranav Modi <pranavmodi@microsoft.com> Reviewed-by: Sanket Joshi <sajos@microsoft.com> Reviewed-by: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1369172}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.