Google Git
Sign in
chromium / chromium / src / 080ddba00693d219b759ac1f718c3a0820f7f0f7
commit080ddba00693d219b759ac1f718c3a0820f7f0f7[log] [tgz]
authorTommy C. Li <tommycli@chromium.org>Thu Feb 16 18:02:59 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 16 18:02:59 2023
treea9d43d6a32be211143a0af8f71df6b6cf68bb1ef
parent0d2c02b73f83d35b3e143d629f06585bfc30fa0b [diff]
[image_service] Remove fetching of images from QueryClustersState

This CL deletes a code path where Chrome fetches salient image URLs
in the C++ handler. (In QueryClustersState specifically).

We tried this as a prototype, but it has a few disadvantages:

 1. It delays sending the Journeys to the DOM, and overall makes
    the latency of painting the Journeys themselves onto the page
    worse.

 2. It prevents the UI from being smart and only requesting images
    once the actual Journey is displayed on-screen.

 3. It's not scalable to NTP Quests or Bookmarks++, because it forces
    frontend devs to write bespoke asynchronous C++ to do it.

We plan to implement this as a Typescript BrowserProxy instead.

Bug: b/244507194, 1367485, b/248367751
Change-Id: I383cb68701b939b0c79b0117698a45435573e8a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4257393
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106299}
10 files changed
tree: a9d43d6a32be211143a0af8f71df6b6cf68bb1ef
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.