Pass custom root view to enable ListMenuButtons inside popup windows This CL allows the user of `ListMenuButton` to pass a custom `RootView` to the `AnchoredPopupWindow`. This is necessary when the `ListMenuButton` is nested inside another popup window. `AnchoredPopupWindow` passes its `mRootView` value to Android's `PopupWindow::showAtLocation()` for Android to get the window token. This value has to match the application's main window's window token. `ListMenuHost` used to pass `mView.getRootView()` to `AnchoredPopupWindow`, which works fine when the `ListMenuButton` is located inside the main application window. However, when the `ListMenuButton` is inside another `PopupWindow`, the root view becomes not the one of the main application window but the one of the popup window. Therefore, we have to manually pass the correct root view of the main application window when the `ListMenuButton` is nested. Bug: 434061282 Change-Id: I64d97781a70a0ba7c98965d22dd20804f517194c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6963975 Reviewed-by: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Masa Fujita <massan@google.com> Cr-Commit-Position: refs/heads/main@{#1519204}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.