Google Git
Sign in
chromium / chromium / src / 08985dafaca72e571068309ad0dd8266574d4edf
commit08985dafaca72e571068309ad0dd8266574d4edf[log] [tgz]
authorW. James MacLean <wjmaclean@chromium.org>Tue Oct 22 14:54:20 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Oct 22 14:54:20 2024
tree8ff9f927de9e913be655928467c02aca8ce1529d
parent856d1de899fb5e13096e6ae56b0a781480aeb59f [diff]
Tweak SurfaceLayerImpl DrawQuad transform for pixel-alignment.

This CL adds code (behind a disabled-by-default feature) to
snap DrawQuads for SurfaceLayerImpl to the pixel grid. This
is necessary to reduce/remove fuzziness in text in out-of-process
iframes (OOPIFs) when a fractional scale-transform is applied
to the OOPIF's owner.

Since this tweak can also affect other users of SurfaceLayerImpl
(e.g. <canvas>), initially this will land disabled.

This CL also adds tests for scaled OOPIFs vs. same-process
iframes (with different scrollbar configurations), and OOPIFs
with a fractional translate-transform. Since the new OOPIF
behavior differs from same-process iframes rendering the same
content, and since the OOPIF behavior appears to be an improvement,
the tests use fuzzy pixel matching to allow these tests to use
the same-process results as reftest expectations. The test are
expected to fail when the feature is not enabled.

Bug: 359279545
Change-Id: Ic8e13a68462f98d39e72a29c809541533933df62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5842653
Commit-Queue: James Maclean <wjmaclean@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1372031}
35 files changed
tree: 8ff9f927de9e913be655928467c02aca8ce1529d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.