Google Git
Sign in
chromium / chromium / src / 08b5eaecf33165cda178517fa4ba070d1f598e16
commit08b5eaecf33165cda178517fa4ba070d1f598e16[log] [tgz]
authorJuliet Levesque <julietlevesque@google.com>Wed Aug 03 20:57:30 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Aug 03 20:57:30 2022
tree6f3bc4a1733fa3e01c6d336d7fd829bf174bd8c7
parent806fd822f682b9eab610277e189429be4d582202 [diff]
[Phone Hub] Prevent UAF in chrome://multidevice-internals

Prevents the fakePhoneHubManager from being created twice UAF security
vulnerability by returning early if its already been set.

even if UAF is attempted

(cherry picked from commit cc950421ca931991f0d39cdc0cabe9c6f2e6e4a3)

Test: Verified on DUT that the fakePhoneHubManager is only created once
Change-Id: Id347e4e17977269be33314e6d90e25533ea646c0
Fixed: 1338412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3788228
Reviewed-by: Jon Mann <jonmann@chromium.org>
Commit-Queue: Juliet Lévesque <julietlevesque@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1028889}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3806035
Cr-Commit-Position: refs/branch-heads/5195@{#192}
Cr-Branched-From: 7aa3f074a7907975b001346cc0288d0214af8451-refs/heads/main@{#1027018}
1 file changed
tree: 6f3bc4a1733fa3e01c6d336d7fd829bf174bd8c7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.