commit 08c5edb4ba142d2b3142b35592d29ec5f146ed98
author Giovanni Ortuño Urquidi <ortuno@chromium.org> Fri Jul 22 06:17:48 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 22 06:17:48 2022
tree 19f82d59712d46da8a6fdfa32e14b0421eba0fb3
parent 5ac65896a7e82c30655f5a3e9983e4dce094af6e

webui: Migrate /chrome/test/base URLDataSources to GetMimeType(GURL)

Changes to override the GURL variant of GetMimeType and where appropriate
changes the overrides' implementations to use the GURL to get a path.

Context:

Many overrides of GetMimeType() do their own parsing, for example, to
turn it back into a GURL[1][2][3], get query params[4], etc. This is
dangerous specially when dealing with untrusted data. Additionally,
the path passed to GetMimeType includes query params and not all
implementations[5] take that into account.

There is now a GetMimeType() virtual function that takes a GURL,
so overrides can use methods like path(), GetPathForRequest(), query(),
etc. to avoid doing manual parsing.

[1] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/search/most_visited_iframe_source.cc;l=58;drc=1560c59051181c15267c40ae37dae98c235feaa0
[2] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/webui/devtools_ui_data_source.cc;l=35-40;drc=1560c59051181c15267c40ae37dae98c235feaa0
[3] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/webui/test_data_source.cc;l=68;drc=1560c59051181c15267c40ae37dae98c235feaa0
[4] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/webui/new_tab_page/untrusted_source.cc;l=196;drc=1560c59051181c15267c40ae37dae98c235feaa0
[5] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ash/web_applications/terminal_source.cc;l=183;drc=1560c59051181c15267c40ae37dae98c235feaa0

This CL was uploaded by git cl split.

R=khorimoto@chromium.org

Bug: 1344742
Change-Id: I8add0d7b7fb8e956f052384701c735df18cb48fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3774562
Auto-Submit: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1027133}